lucasfang opened a new pull request, #217:
URL: https://github.com/apache/paimon-cpp/pull/217

   ### Purpose
   
   Linked issue: close #xxx
   
   `cmake_modules/arrow.diff` (the patch applied to the bundled Arrow 
ExternalProject via `PATCH_COMMAND` in 
`cmake_modules/ThirdpartyToolchain.cmake`) had its patch sections in an ad-hoc 
order accumulated over time. This change reorganizes the file so the per-file 
patch sections are ordered consistently by file path (cmake modules first, then 
`arrow/io`, then `parquet/`), and splits hunks under their proper file headers 
(14 sections instead of 10, e.g. `parquet/arrow/reader.h`, 
`parquet/arrow/reader_internal.h`, `parquet/file_reader.cc`, 
`parquet/file_reader.h` now carry their own sections).
   
   This is a pure reformat/reorder: every added and removed patch line was 
verified to be byte-for-byte identical to the previous version (compared with 
direction-aware line-by-line diff of all `+`/`-` lines), so the patch applied 
to the Arrow source is semantically unchanged and the Arrow build behavior is 
not affected.
   
   ### Tests
   
   No behavior change, so no new UT/IT cases. Verified by comparing the old and 
new `arrow.diff`: the multiset of all added and removed patch lines is 
identical between the two versions, which guarantees the patch applies the same 
changes to the Arrow source. The Arrow ExternalProject rebuild in CI will 
additionally confirm the reformatted patch still applies cleanly.
   
   ### API and Format
   
   No. This change only touches `cmake_modules/arrow.diff` (a build-time patch 
file); it does not affect any public API under `include/`, the storage format, 
or any protocol.
   
   ### Documentation
   
   No new feature; no documentation change needed.
   
   ### Generative AI tooling
   
   Generated-by: Qoder
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to