lxy-9602 commented on code in PR #216: URL: https://github.com/apache/paimon-cpp/pull/216#discussion_r3810346816
########## src/paimon/format/orc/orc_file_batch_reader.cpp: ########## Review Comment: Why not just change `target_column_ids->push_back(src_type->getColumnId());` in default case to `CollectAllColumnIds(src_type, target_column_ids);`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
