SteNicholas commented on code in PR #209:
URL: https://github.com/apache/paimon-cpp/pull/209#discussion_r3814051345
##########
include/paimon/read_context.h:
##########
@@ -307,13 +306,13 @@ class PAIMON_EXPORT ReadContextBuilder {
/// @return Reference to this builder for method chaining.
ReadContextBuilder& EnablePrefetch(bool enabled);
- /// Set prefetch cache mode for read operations.
+ /// Enable or disable the read-ahead cache for read operations.
///
- /// A prefetch cache is used to prebuffer data ranges before they are
needed,
+ /// A read-ahead cache is used to prebuffer data ranges before they are
needed,
/// which can improve read performance by reducing redundant I/O
operations.
- /// @param mode (default: PrefetchCacheMode::ALWAYS)
+ /// @param enabled Whether to enable the read-ahead cache (default: true)
/// @return Reference to this builder for method chaining.
- ReadContextBuilder& SetPrefetchCacheMode(PrefetchCacheMode mode);
+ ReadContextBuilder& SetReadAheadCacheEnabled(bool enabled);
Review Comment:
Preserve the exported cache API. This replaces SetPrefetchCacheMode and its
getter while also removing the public PrefetchCacheMode enum, the four-argument
CacheConfig constructor, buffer-size accessors, and the installed
read_ahead_cache.h header. Existing consumers will fail to compile, and the
boolean cannot express the EXCLUDE_* modes. Preserve deprecated compatibility
wrappers and the old header, or stage this as an explicit breaking API change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
