JingsongLi commented on code in PR #9283:
URL: https://github.com/apache/paimon/pull/9283#discussion_r3818061939
##########
paimon-api/src/main/java/org/apache/paimon/Snapshot.java:
##########
@@ -206,6 +214,7 @@ public Snapshot(
@Nullable Long changelogManifestListSize,
@Nullable String indexManifest,
String commitUser,
+ @Nullable String fullVersion,
Review Comment:
[P1] Preserve the existing public constructor signatures. `Snapshot` is
annotated `@Public`, and inserting `fullVersion` into both constructors removes
the old JVM descriptors. Any external connector or application compiled against
the current API that calls either constructor will fail after upgrading with
`NoSuchMethodError` (and source consumers no longer compile), even though the
new JSON field itself is optional. Please keep overloads with the old parameter
lists that delegate to the new constructors with a null full version; the same
compatibility treatment is prudent for the public `Tag`/`Changelog`
constructors changed in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
