zhf999 commented on code in PR #207:
URL: https://github.com/apache/paimon-cpp/pull/207#discussion_r3819078886
##########
src/paimon/format/parquet/page_filtered_row_group_reader.cpp:
##########
@@ -397,12 +397,14 @@ Result<std::unique_ptr<arrow::RecordBatchReader>>
PageFilteredRowGroupReader::Re
std::vector<std::shared_ptr<arrow::ChunkedArray>> result_arrays;
result_arrays.reserve(field_indices.size());
+ std::shared_ptr<std::unordered_set<int>> col_indices_set(new
std::unordered_set<int>());
+ col_indices_set->insert(column_indices.begin(), column_indices.end());
// TODO(zhouhongfeng.zhf): This loop could be parallelized.
Review Comment:
`included_leaves` is a `std::shared_ptr<std::unordered_set<int>>`, so we
must use a `shared_ptr`.
The way we constuct `shared_ptr` has been changed to `make_shared`, and we
make the function parameter `const shared_ptr<std::unordered_set<int>>&`, this
also aligns with the signature of Arrow function `GetFieldReader`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
