lxy-9602 commented on code in PR #226:
URL: https://github.com/apache/paimon-cpp/pull/226#discussion_r3820372341
##########
src/paimon/format/parquet/parquet_writer_builder.cpp:
##########
@@ -86,6 +86,11 @@ Result<std::shared_ptr<::parquet::WriterProperties>>
ParquetWriterBuilder::Prepa
OptionsUtils::GetValueFromMap<int64_t>(options_,
PARQUET_PAGE_SIZE,
::parquet::kDefaultDataPageSize));
builder.data_pagesize(page_size);
+ PAIMON_ASSIGN_OR_RAISE(
+ int64_t page_row_count_limit,
+ OptionsUtils::GetValueFromMap<int64_t>(options_,
PARQUET_PAGE_ROW_COUNT_LIMIT,
+
::parquet::DEFAULT_DATA_PAGE_ROW_COUNT_LIMIT));
+ builder.data_page_row_count_limit(page_row_count_limit);
Review Comment:
`parquet.page.row.count.limit <= 0` is not validated, even though parquet-mr
requires this value to be greater than zero. I suggest returning Invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
