HaHaJeff commented on code in PR #224:
URL: https://github.com/apache/paimon-cpp/pull/224#discussion_r3828374192
##########
src/paimon/core/realtime/realtime_context_impl.cpp:
##########
@@ -78,27 +78,37 @@ Status RealtimeContextImpl::Start() {
}
Result<RealtimeStoreState> RealtimeContextImpl::GetOrCreateRealtimeStore(
- const std::map<std::string, std::string>& partition, int32_t bucket,
- std::unique_ptr<ArrowSchema> write_schema, const std::map<std::string,
std::string>& options,
- const std::shared_ptr<MemoryPool>& memory_pool) {
+ RealtimeStoreCreateRequest&& request) {
std::lock_guard<std::mutex> progress_lock(progress_mutex_);
std::lock_guard<std::mutex> registry_lock(mutex_);
- const RealtimePartitionBucket key(partition, bucket);
+ const RealtimePartitionBucket key(request.partition, request.bucket);
+ std::optional<int64_t> initial_max_sequence_number;
+ PrimaryKeyRealtimeStoreCreateConfig* primary_key_config =
+ std::get_if<PrimaryKeyRealtimeStoreCreateConfig>(&request.mode_config);
+ if (primary_key_config) {
+ auto [sequence_iter, inserted] =
materialized_max_sequence_numbers_.emplace(
+ key, primary_key_config->restore_max_sequence_number);
+ if (!inserted && primary_key_config->restore_max_sequence_number >
sequence_iter->second) {
Review Comment:
Fixed in 5f74e463. Reusing an existing PK realtime store now rejects a
restore watermark above its materialized watermark, preventing the store and
writer sequence allocators from diverging; the context test covers this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
