plusplusjiajia commented on code in PR #733:
URL: https://github.com/apache/paimon-rust/pull/733#discussion_r3830305439
##########
crates/paimon/src/catalog/filesystem.rs:
##########
@@ -297,30 +354,26 @@ impl Catalog for FileSystemCatalog {
}
async fn get_table(&self, identifier: &Identifier) -> Result<Table> {
- identifier.validate()?;
-
- let table_path = self.table_path(identifier);
+ let (table_path, schema) = self.fetch_table_schema(identifier).await?;
+ self.build_table(identifier, table_path, schema)
+ }
- if !self.table_exists(identifier).await? {
- return Err(Error::TableNotExist {
- full_name: identifier.full_name(),
- });
+ async fn load_table_routing(
+ &self,
+ identifier: &Identifier,
+ engine_types: &std::collections::HashSet<TableType>,
+ ) -> Result<crate::catalog::RoutedTableLoad> {
+ let (table_path, schema) = self.fetch_table_schema(identifier).await?;
+ let options = CoreOptions::new(schema.options());
+ let declared = options.table_type()?;
Review Comment:
@JingsongLi Agreed, rejecting unknown values wasn't enough. Done:
alter_table rejects any change or removal of type, allowing only
case-insensitive no-ops, matching SchemaManager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
