lxy-9602 commented on code in PR #213:
URL: https://github.com/apache/paimon-cpp/pull/213#discussion_r3840529343
##########
src/paimon/core/operation/file_store_commit_impl.cpp:
##########
@@ -931,6 +936,30 @@ Result<int64_t> FileStoreCommitImpl::CommitWithProgress(
std::shared_ptr<ManifestCommittable> committable =
CreateManifestCommittable(identifier, commit_messages, watermark,
/*properties=*/{});
+ PAIMON_ASSIGN_OR_RAISE(std::vector<std::shared_ptr<ManifestCommittable>>
pending_committables,
+ FilterCommitted({committable}));
+ const bool identifier_committed = pending_committables.empty();
Review Comment:
Thanks for pointing this out. `CommitWithProgress` intentionally follows the
same identifier high-watermark semantics as `FilterAndCommit`; its return value
is the latest snapshot covering the requested offset progress, so it can be
passed to `RefreshCommittedSnapshot`. It is not intended to identify the exact
snapshot produced by the retried commit.
I’ve clarified this contract in the API documentation and added a test
covering A → B → retry A, where the retry returns B’s latest snapshot ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
