zhf999 commented on code in PR #243:
URL: https://github.com/apache/paimon-cpp/pull/243#discussion_r3848946673
##########
src/paimon/core/operation/abstract_split_read.cpp:
##########
@@ -152,13 +153,17 @@ Result<std::unique_ptr<ReaderBuilder>>
AbstractSplitRead::PrepareReaderBuilder(
Result<std::unique_ptr<FileBatchReader>>
AbstractSplitRead::CreateFileBatchReader(
const std::string& file_format_identifier, const std::string&
data_file_path,
- int64_t data_file_size, const ReaderBuilder* reader_builder) const {
+ int64_t data_file_size, std::unique_ptr<ReaderBuilder> reader_builder)
const {
if (context_->EnablePrefetch() && file_format_identifier != "blob" &&
file_format_identifier != "avro") {
+ if (context_->EnableLateMaterializing()) {
Review Comment:
Nice proposal, I will change this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
