lxy-9602 commented on code in PR #224:
URL: https://github.com/apache/paimon-cpp/pull/224#discussion_r3850158946
##########
include/paimon/realtime/realtime_store.h:
##########
@@ -41,10 +43,42 @@ namespace paimon {
class MemoryPool;
class Predicate;
-/// A table record batch and its framework-assigned contiguous offset range.
+struct PAIMON_EXPORT AppendRealtimeStoreCreateConfig {
+ StatisticsMode statistics_mode;
+};
+
+struct PAIMON_EXPORT PrimaryKeyRealtimeStoreCreateConfig {
+ /// Primary-key fields after removing partition fields, in comparison
order.
+ std::vector<std::string> trimmed_primary_keys;
+};
Review Comment:
Why does store need the PK field here? It seems this may be for preparing
`key_comparator_`, but in earlier discussions we explicitly agreed to remove
sorting from the plugin side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
