zjw1111 commented on code in PR #249:
URL: https://github.com/apache/paimon-cpp/pull/249#discussion_r3868643946
##########
src/paimon/common/utils/options_utils.h:
##########
@@ -89,13 +89,29 @@ class OptionsUtils {
return value.status();
}
+ static Result<std::string> GetNonEmptyValueFromMap(
+ const std::map<std::string, std::string>& key_value_map, const
std::string& key) {
+ Result<std::string> value =
GetValueFromMap<std::string>(key_value_map, key);
+ if (!value.ok()) {
+ return value.status();
+ }
+ if (value.value().empty()) {
+ return Status::Invalid(fmt::format("value for key {} must not be
empty", key));
+ }
+ return value.value();
+ }
+
/// Fetch options with specific prefix and remove prefix for key.
+ ///
+ /// If `ignore_empty_key` is true, an option whose key equals `prefix` is
ignored.
Review Comment:
use doxygen format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
