jerry-024 commented on code in PR #749:
URL: https://github.com/apache/paimon-rust/pull/749#discussion_r3870092021
##########
crates/paimon/src/catalog/mod.rs:
##########
@@ -263,14 +263,16 @@ use async_trait::async_trait;
use crate::api::PagedList;
use crate::spec::{Partition, Schema, SchemaChange, TableType};
-use crate::table::Table;
+use crate::table::{ObjectTable, Table};
/// Outcome of [`Catalog::load_table`].
#[derive(Debug)]
pub enum LoadedTable {
/// A constructed Paimon table (boxed: far larger than the other variant).
Paimon(Box<Table>),
- /// A table this reader cannot construct.
+ /// A native read-only object table.
+ Object(ObjectTable),
+ /// A table that needs a registered external engine.
Review Comment:
<!-- dlf-review -->
**[MAJOR]** Adding `Object` to the public, exhaustive `LoadedTable` enum is
a breaking API change: downstream crates with exhaustive matches will fail to
compile after upgrading, even if they never use object tables.
Please treat and document this as a semver-breaking release. If more table
kinds are expected, consider marking the enum `#[non_exhaustive]` in the same
breaking release so subsequent variants do not repeatedly break consumers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
