lxy-9602 commented on code in PR #255:
URL: https://github.com/apache/paimon-cpp/pull/255#discussion_r3878221057
##########
src/paimon/core/global_index/indexed_split_test.cpp:
##########
@@ -155,6 +157,25 @@ TEST(IndexedSplitTest, TestIndexedSplitWithScore) {
<< roundtrip_indexed_split->ToString();
}
+TEST(IndexedSplitTest, TestSerializeCanonicalizesNaNScore) {
+ auto pool = GetDefaultPool();
+ DataSplitImpl::Builder builder(
+ /*partition=*/BinaryRow::EmptyRow(),
+ /*bucket=*/0, /*bucket_path=*/"bucket-0",
+ /*data_files=*/{});
+ ASSERT_OK_AND_ASSIGN(std::shared_ptr<Split> data_split, builder.Build());
+
+ const float payload_nan = FloatingPointFromBits<float>(0xffc12345U);
+ auto indexed_split = std::make_shared<IndexedSplitImpl>(
+ std::dynamic_pointer_cast<DataSplitImpl>(data_split),
std::vector<Range>{Range(0, 0)},
+ std::vector<float>{payload_nan});
+
+ ASSERT_OK_AND_ASSIGN(std::string serialized,
Split::Serialize(indexed_split, pool));
+ ASSERT_GE(serialized.size(), sizeof(float));
+ ASSERT_EQ(serialized.substr(serialized.size() - sizeof(float)),
+ std::string("\x7f\xc0\x00\x00", sizeof(float)));
Review Comment:
I’m not sure this test is ideal in its current form, because if the protocol
evolves or the serialization format changes later, we can’t really guarantee
that reading the last 4 bytes will still correspond to the `score` field.
##########
src/paimon/core/global_index/indexed_split_test.cpp:
##########
@@ -155,6 +157,25 @@ TEST(IndexedSplitTest, TestIndexedSplitWithScore) {
<< roundtrip_indexed_split->ToString();
}
+TEST(IndexedSplitTest, TestSerializeCanonicalizesNaNScore) {
+ auto pool = GetDefaultPool();
+ DataSplitImpl::Builder builder(
+ /*partition=*/BinaryRow::EmptyRow(),
+ /*bucket=*/0, /*bucket_path=*/"bucket-0",
+ /*data_files=*/{});
+ ASSERT_OK_AND_ASSIGN(std::shared_ptr<Split> data_split, builder.Build());
Review Comment:
`ASSERT_OK_AND_ASSIGN(std::shared_ptr<DataSplitImpl> data_split,
builder.Build());`
##########
src/paimon/core/global_index/indexed_split_test.cpp:
##########
@@ -155,6 +157,25 @@ TEST(IndexedSplitTest, TestIndexedSplitWithScore) {
<< roundtrip_indexed_split->ToString();
}
+TEST(IndexedSplitTest, TestSerializeCanonicalizesNaNScore) {
+ auto pool = GetDefaultPool();
+ DataSplitImpl::Builder builder(
+ /*partition=*/BinaryRow::EmptyRow(),
+ /*bucket=*/0, /*bucket_path=*/"bucket-0",
+ /*data_files=*/{});
+ ASSERT_OK_AND_ASSIGN(std::shared_ptr<Split> data_split, builder.Build());
+
+ const float payload_nan = FloatingPointFromBits<float>(0xffc12345U);
+ auto indexed_split = std::make_shared<IndexedSplitImpl>(
+ std::dynamic_pointer_cast<DataSplitImpl>(data_split),
std::vector<Range>{Range(0, 0)},
+ std::vector<float>{payload_nan});
+
+ ASSERT_OK_AND_ASSIGN(std::string serialized,
Split::Serialize(indexed_split, pool));
+ ASSERT_GE(serialized.size(), sizeof(float));
+ ASSERT_EQ(serialized.substr(serialized.size() - sizeof(float)),
+ std::string("\x7f\xc0\x00\x00", sizeof(float)));
Review Comment:
Please also test `Deserialize`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
