XiaoHongbo-Hope commented on code in PR #9461:
URL: https://github.com/apache/paimon/pull/9461#discussion_r3885851567
##########
paimon-python/pypaimon/read/reader/format_blob_reader.py:
##########
@@ -290,6 +306,17 @@ def close(self):
self._input_stream = None
def _read_index(self) -> None:
+ if self._is_video:
+ self._video_meta = VideoFileMeta(
+ self._input_stream, self._file_size
+ )
+ # BlobFallbackBatchReader uses this public list for the selected
+ # logical row count. Video rows have no ordinary BLOB lengths, so
+ # retain count-only sentinels and let VideoFileMeta resolve them.
+ self.blob_lengths = [0] * self._video_meta.record_count
+ self.blob_offsets = [0] * self._video_meta.record_count
+ return
Review Comment:
We can expose record_count directly from _video_meta instead of allocating
these two O(frame count) lists?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
