JunRuiLee commented on PR #752: URL: https://github.com/apache/paimon-rust/pull/752#issuecomment-5470447353
Confirmed, and reachable: the vindex index builder aborts messages holding global index files, and `try_commit` aborts whatever it was committing. Fixed in 8f92627. `abort` now classifies each index file rather than resolving the whole message as bucket-local: - no `_GLOBAL_INDEX` → bucket-local (deletion vectors, the dynamic-bucket hash index); - a `_GLOBAL_INDEX` whose `_SOURCE_META` is absent — what this crate's index builders write — or whose `_SOURCE_META` carries `DataEvolutionIndexSourceMeta`'s `DEIX` marker → global; - anything else → bucket-local, which is what Java assumes for every index file. Both abort tests now also plant a same-named file in the other layout and assert it survives, so neither direction can regress into deleting a path the commit does not own. One thing I ran into while checking this against Java: `FileStoreCommitImpl.abort` resolves every `newIndexFiles()` entry through `IndexFilePathFactories.get(partition, bucket)`, while `SortedGlobalIndexWriter.flushIndex` writes through `globalIndexFileFactory()` and returns those metas in `DataIncrement.indexIncrement(...)`. So with `index-file-in-data-file-dir` set, Java leaves the same orphan behind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
