jerry-024 commented on code in PR #760:
URL: https://github.com/apache/paimon-rust/pull/760#discussion_r3892670734
##########
crates/paimon/src/lumina/reader.rs:
##########
@@ -369,7 +369,7 @@ fn search_lumina_batch(
}
if vector_searches
.iter()
- .any(|vector_search| vector_search.include_row_ids.is_some())
+ .any(|vector_search|
vector_search.effective_include_row_ids().is_some())
{
Review Comment:
<!-- dlf-review -->
**[MAJOR]** Filtered batch searches discard Lumina batch execution and
rebuild the same shared allow-list once per query. Each fallback call
materializes the shared `RoaringTreemap` into a new `Vec<u64>`, producing `O(Q
* B)` conversion/allocation work plus Q sequential searches per shard.
When every query shares the same bitmap, materialize it once and call
`search_with_filter` with the full query batch. Keep the per-query fallback
only for differing filters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
