zjw1111 commented on code in PR #260:
URL: https://github.com/apache/paimon-cpp/pull/260#discussion_r3893196913
##########
include/paimon/reader/batch_reader.h:
##########
@@ -45,6 +45,12 @@ class PAIMON_EXPORT BatchReader {
/// retried, as it will repeatedly return the same error code.
/// \note IMPORTANT: A non-EOF ArrowArray and all its nested child arrays
must have offset 0 to
/// avoid potential issues during conversion through the Arrow C Data
Interface.
+ /// \note A returned ArrowArray must retain every allocator and plugin
resource needed by its
Review Comment:
use warning or important, and change `\` to `@`
##########
src/paimon/common/utils/arrow/mem_utils.h:
##########
@@ -33,7 +34,16 @@ namespace paimon {
PAIMON_EXPORT std::unique_ptr<arrow::MemoryPool> GetArrowPool(
const std::shared_ptr<MemoryPool>& pool);
-Status RetainArrowArrayMemoryPool(ArrowArray* array,
- const std::shared_ptr<arrow::MemoryPool>&
arrow_pool);
+PAIMON_EXPORT std::shared_ptr<arrow::MemoryPool> GetSharedArrowPool(
Review Comment:
delete GetSharedArrowPool, GetArrowPool -> shared_ptr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
