zjw1111 commented on code in PR #264:
URL: https://github.com/apache/paimon-cpp/pull/264#discussion_r3893803910
##########
src/paimon/core/catalog/file_system_catalog.cpp:
##########
@@ -123,7 +127,8 @@ Result<bool> FileSystemCatalog::TableExists(const
Identifier& identifier) const
}
std::string FileSystemCatalog::GetDatabaseLocation(const std::string& db_name)
const {
- return NewDatabasePath(warehouse_, db_name);
+ // An invalid name has no valid location, keep the same convention as
RestCatalog.
+ return NewDatabasePath(warehouse_, db_name).value_or("");
Review Comment:
why not return `Result`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
