lxy-9602 commented on code in PR #275:
URL: https://github.com/apache/paimon-cpp/pull/275#discussion_r3912459137
##########
src/paimon/core/io/row_to_arrow_array_converter.h:
##########
@@ -158,6 +158,12 @@ Status RowToArrowArrayConverter<T,
R>::Reserve(arrow::ArrayBuilder* array_builde
PAIMON_RETURN_NOT_OK(Reserve(list_builder->value_builder(), idx));
break;
}
+ case arrow::Type::type::FIXED_SIZE_LIST: {
+ PAIMON_ASSIGN_OR_RAISE(arrow::FixedSizeListBuilder * list_builder,
Review Comment:
May use `auto*` here to avoid formatting issues.
##########
src/paimon/core/schema/schema_validation_test.cpp:
##########
@@ -116,12 +157,6 @@ TEST(SchemaValidationTest, TestVectorType) {
/*primary_keys=*/{},
data_evolution_options));
ASSERT_NOK_WITH_MSG(SchemaValidation::ValidateTableSchema(*table_schema),
"VECTOR fields in data-evolution tables are not
implemented yet.");
- ASSERT_OK_AND_ASSIGN(table_schema,
- TableSchema::Create(/*schema_id=*/0, nested_schema,
- /*partition_keys=*/{},
- /*primary_keys=*/{},
data_evolution_options));
- ASSERT_NOK_WITH_MSG(SchemaValidation::ValidateTableSchema(*table_schema),
- "VECTOR fields in data-evolution tables are not
implemented yet.");
Review Comment:
I’m wondering why this test was removed.
##########
test/inte/write_and_read_inte_test.cpp:
##########
@@ -678,6 +678,60 @@ TEST_P(WriteAndReadInteTest, TestPKSimple) {
ASSERT_TRUE(success);
}
+TEST_P(WriteAndReadInteTest, TestPKVector) {
+ auto [file_format, file_system] = GetParam();
+ if (file_format != "parquet") {
+ return;
+ }
+
Review Comment:
It looks like the current PR is intended to support merge functions for all
types. Please update the issue description accordingly, and also add tests for
listagg and spill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
