QuakeWang commented on code in PR #784:
URL: https://github.com/apache/paimon-rust/pull/784#discussion_r3914753055
##########
docs/src/go-binding.md:
##########
@@ -147,8 +147,8 @@ catalog, err := paimon.NewCatalog(map[string]string{
"token.provider": "dlf",
"dlf.region": os.Getenv("DLF_REGION"),
"dlf.oss-endpoint": os.Getenv("DLF_OSS_ENDPOINT"),
- "dlf.token-loader": "ecs",
- "dlf.token-ecs-role-name": os.Getenv("DLF_ECS_ROLE"),
+ "dlf.access-key-id": os.Getenv("DLF_ACCESS_KEY_ID"),
Review Comment:
This changes the DLF example from the ECS RAM-role loader to static
credentials, which is unrelated to MAP<K, BLOB> support and drops automatic
credential refresh. Please revert it here or move it to a separate PR with its
own rationale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
