lxy-9602 commented on code in PR #269:
URL: https://github.com/apache/paimon-cpp/pull/269#discussion_r3915124913
##########
include/paimon/realtime/offset_range.h:
##########
@@ -29,7 +29,8 @@ namespace paimon {
struct PAIMON_EXPORT OffsetRange {
OffsetRange(int64_t begin, int64_t end) : begin(begin), end(end) {}
- /// Returns the number of offsets covered by this range.
+ /// Returns the width of this range. Real-time offsets may have gaps, so
this is not a row
+ /// count.
int64_t Count() const {
Review Comment:
Given that `OffsetRange` may be non-contiguous now, I removed this `Count`
API to avoid ambiguity. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
