shyjsarah commented on PR #782: URL: https://github.com/apache/paimon-rust/pull/782#issuecomment-5522272715
Correction to my earlier review: the retry-window finding was based on Java `release-1.3`, which used 1-second retry intervals. This PR explicitly targets Java **master**, and current Java master uses the same 10 attempts with 200-ms intervals as this Rust implementation. Therefore, the retry behavior is compatible with the stated target and that finding should be disregarded. I rechecked commit `d095349`: the POSIX backslash-ID issue is fixed, the bounded-concurrency change looks good, and the targeted tests/clippy pass. No remaining blocking findings from my review. Sorry for the baseline mismatch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
