JingsongLi commented on PR #9466: URL: https://github.com/apache/paimon/pull/9466#issuecomment-5523122928
Thanks for putting this together. This PR currently combines two independently valuable changes with different review and risk profiles: the generic ContiguousWindowDataset public API, and the RoboMIND ACT benchmark harness and workflow. Given the 4.4k-line scope, could we split this into two PRs? 1. Contiguous-window Dataset: the public API, row-ID and snapshot semantics, BLOB handling, batching behavior, tests, and API documentation. 2. ACT benchmark: the prepare/run/compare workflow, backend adapters, packaging, benchmark documentation, and ideally a real paired Vortex result artifact with variance and physical-layout identity. This would make the public API easier to review on its own, while allowing the benchmark methodology and reproducibility contract to be evaluated independently. It would also keep follow-up fixes in either area from blocking the other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
