JingsongLi commented on PR #9402:
URL: https://github.com/apache/paimon/pull/9402#issuecomment-5534936489

   [P2] Apply schema compatibility to the explicit-file scanner overload too
   
   `DataEvolutionGlobalIndexScanner.create(FileStoreTable, ..., 
Collection<IndexFileMeta>)` still feeds caller-supplied files directly into 
readers and coverage, while only the manifest-discovering overload filters 
incompatible entries. A caller that scans the manifest and passes those metas 
after an indexed type evolution can therefore open the old serializer and count 
the old range as covered, reintroducing the false-negative path this PR is 
fixing. Current vector planning usually passes already-filtered files, but 
direct callers of this public API are unprotected.
   
   Java metas now transport `schemaId`, so the overload can validate them 
against the pinned/current table schema before constructing coverage. Python 
has the same bypass in `data_evolution_global_index_scanner.py:166-181`, but 
its `IndexFileMeta` does not preserve schema identity, so that API needs either 
manifest entries or schema identity in the transported meta. Please add 
direct-overload regression tests after a type evolution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to