thswlsqls opened a new pull request, #9605:
URL: https://github.com/apache/paimon/pull/9605

   ### Purpose
   
   fix #9559
   
   - `VortexFileFormat.createWriterFactory()` never passed `write.batch-memory` 
to `ArrowFormatCWriter`, so only `write.batch-size` bounded a batch. This 
passes it through.
   - #7543 passed it; #8040 dropped it when `ArrowFormatCWriter` replaced 
`ArrowFormatWriter`. If that was intentional, please close this — #9559 asks 
the same.
   - Among Arrow-VSR-backed native writers, orc, lance and mosaic already 
consume it; vortex did not. parquet/avro do not use it.
   - Defaults (128 MB) are unaffected; the limit bites only with a lowered 
option or very wide rows.
   - No docs change: the option is already generated from the untouched 
`CoreOptions`.
   
   ### Tests
   
   - Added `VortexFileFormatTest#testWriterFactoryHonorsWriteBatchMemory`: at a 
1 kb limit `write()` is rejected before `write.batch-size`; at 128 MB it is not.
   - `mvn -pl paimon-vortex/paimon-vortex-format clean install` (JDK 11) — 66 
tests, 0 failures, 4 skipped; checkstyle, spotless, enforcer green.
   - No existing test sets `write.batch-memory`, so none change behavior.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to