thswlsqls commented on issue #9604:
URL: https://github.com/apache/paimon/issues/9604#issuecomment-5536113566
Three corrections to the report above, plus one caveat I should have
included.
**1. Plugin version in the repro line.** Paimon resolves
maven-dependency-plugin 3.1.1, so at the repo root with Maven 3.9.16 the actual
line is
```
[INFO] --- dependency:3.1.1:tree (default-cli) @ paimon-parent ---
```
not `3.7.0`. That version came from a bare scratch pom I used to isolate the
logging change, and I should not have carried it into a line labelled `@
paimon-parent`. The goal-prefix behaviour itself is unchanged: no
`maven-dependency-plugin` string is emitted either way.
Also worth stating precisely: `dependency:tree` is not on the broken path.
`NoticeFileChecker.run()` consumes `ShadeParser`,
`DependencyParser.parseDependencyCopyOutput` and
`DeployParser.parseDeployOutput`. Run 33834803761 contains 75
`deploy:2.8.2:deploy`, 6 `dependency:3.1.1:copy` and 8
`dependency:3.1.1:unpack` lines, and zero `dependency:*:tree` lines.
**2. Line numbers.** `DeployParser.java:47` is right; the `DependencyParser`
ones are off by three. On ffe8e5127 the regexes are at
`DependencyParser.java:44` (copy) and `:48` (tree).
**3. A fourth regex I missed.** `ScalaSuffixChecker.java:50` carries the
same artifactId-only pattern:
```java
Pattern.compile(".* --- maven-dependency-plugin.* @ (.*) ---.*");
```
Flink fixed this one in the same commit (apache/flink@e3a53a5). No Paimon CI
job invokes `ScalaSuffixChecker` today, so nothing is silently broken by it,
but it belongs in the same fix to keep the tree consistent.
**Caveat on the 229.** A subset may be checker false positives, where a
shade `<filters>` block strips an artifact's classes while the `Including ...`
log line survives. So 229 is an upper bound until the jars themselves are
measured. The parser bug and the missing `paimon-jindo` NOTICE are unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
