wangzhigang1999 commented on code in PR #87:
URL:
https://github.com/apache/paimon-vector-index/pull/87#discussion_r3935411051
##########
python/paimon_vindex/__init__.py:
##########
@@ -512,6 +521,15 @@ def __init__(self, training: VectorIndexTraining):
_check_error("failed to open writer")
self._dimension = self._read_dimension()
+ @classmethod
+ def _from_handle(cls, handle):
+ writer = cls.__new__(cls)
Review Comment:
Thanks @JingsongLi, fixed in ddf6b4a. I added fault-injection tests before
and after handle assignment, and all CI checks pass. Could you take another
look when you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
