Stefanietry commented on code in PR #9598:
URL: https://github.com/apache/paimon/pull/9598#discussion_r3946962731
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/PaimonPartitionReaderFactory.scala:
##########
@@ -29,13 +30,19 @@ import java.util.Objects
case class PaimonPartitionReaderFactory(
readBuilder: ReadBuilder,
metadataColumns: Seq[PaimonMetadataColumn] = Seq.empty,
- blobAsDescriptor: Boolean)
+ blobAsDescriptor: Boolean,
+ uriReaderFactory: UriReaderFactory = null)
Review Comment:
Thanks for catching this. I've updated the code accordingly.
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/read/BaseScan.scala:
##########
@@ -144,7 +144,16 @@ trait BaseScan extends Scan with SupportsReportStatistics
with Logging {
override def toBatch: Batch = {
val metadataColumns = metadataFields.map(
field => PaimonMetadataColumn.get(field.name,
SparkTypeUtils.toSparkPartitionType(table)))
- PaimonBatch(inputPartitions, readBuilder, coreOptions.blobAsDescriptor(),
metadataColumns)
+ val uriReaderFactory = table match {
+ case fileStoreTable: FileStoreTable =>
BlobDescriptorReaderFactory.create(fileStoreTable)
Review Comment:
Thanks for catching this. I've updated the code accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
