zhuxiangyi commented on PR #9667:
URL: https://github.com/apache/paimon/pull/9667#issuecomment-5601514357

   Both review findings are addressed in 5931ce7b7, with replies in the two 
threads. In short: the commit user is now derived from the query id Spark 
persists in the checkpoint rather than from the checkpoint location, because 
what it has to identify is one incarnation of a checkpoint and not where it is 
stored; and `InnerTableCommit` gained `inlineMaintenance`, which the sink uses 
so that a committer closed after every micro-batch finishes maintenance and 
propagates its failure. Both defects were reproduced before being fixed, and 
the tests that reproduced them are in the suite, which now has 10 cases and was 
run on the 3.2, 3.4, 3.5, 4.0 and 4.1 modules.
   
   One CI job is red for an unrelated reason. `build` (run 34327655817) failed 
while resolving dependencies for `paimon-iceberg`:
   
   ```
   Failed to read artifact descriptor for 
org.eclipse.jetty:jetty-server:jar:12.1.8
     Caused by: io.netty:netty-bom:pom:4.2.12.Final (absent):
       status code: 502, reason phrase: Bad Gateway (502)
   ```
   
   Maven Central returned 502, and Maven cached the failure so it is not 
retried within the job. It failed before compiling anything, this change 
touches no Iceberg module, and the other four `build` jobs on the same commit 
passed. Could a committer re-run that job when convenient? I have no permission 
to do so on the repository.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to