lxy-9602 commented on code in PR #318:
URL: https://github.com/apache/paimon-cpp/pull/318#discussion_r3976490809
##########
test/inte/write_and_read_inte_test.cpp:
##########
@@ -357,6 +357,113 @@ TEST_P(WriteAndReadInteTest, TestAppendSimple) {
ASSERT_TRUE(success);
}
+TEST_P(WriteAndReadInteTest, TestAppendReadWithNestedPredicateAcrossBatches) {
+ auto [file_format, file_system] = GetParam();
+ arrow::FieldVector fields = {
+ arrow::field("id", arrow::int32()), arrow::field("key",
arrow::int64()),
+ arrow::field("value", arrow::utf8()), arrow::field("payload",
arrow::binary())};
+ std::map<std::string, std::string> options = {
+ {Options::FILE_FORMAT, file_format},
+ {Options::FILE_SYSTEM, file_system},
+ {Options::BUCKET, "-1"},
+ {Options::TARGET_FILE_SIZE, "1048576"},
+ };
+ if (file_system == "jindo") {
+ options = AddOptionsForJindo(options);
+ }
+ ASSERT_OK_AND_ASSIGN(auto helper,
+ TestHelper::Create(test_dir_, arrow::schema(fields),
/*partition_keys=*/{},
+ /*primary_keys=*/{}, options,
+ /*is_streaming_mode=*/false));
+ // With four rows per batch, the AND predicate sees empty, partial, full,
empty,
+ // partial, and full matches. Rows 4 and 6 are identical and must both
survive.
+ const std::string data_json = R"([
Review Comment:
I’m not sure I fully understand this comment. From the test, it seems the
intent is to verify `EnablePredicateFilter`, so I wasn’t sure where “With four
rows per batch” comes from. Could you clarify whether this refers to the write
configuration or the read/query configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
