zjw1111 commented on code in PR #324:
URL: https://github.com/apache/paimon-cpp/pull/324#discussion_r3978439050
##########
include/paimon/realtime/realtime_context.h:
##########
@@ -65,6 +66,17 @@ struct PAIMON_EXPORT RealtimePartitionBucket {
/// Exclusive committed end offset for each partition-bucket.
using RealtimeOffsetMap = std::map<RealtimePartitionBucket, int64_t>;
+/// Gauge names exposed by `RealtimeContext::GetMetrics` and real-time
file-store writers.
+class PAIMON_EXPORT RealtimeMetrics {
+ public:
+ static constexpr char BUILDING_MEMORY_BYTES[] =
"realtimeBuildingMemoryBytes";
Review Comment:
These new public constants should follow the repository's `k` + PascalCase
convention (`kBuildingMemoryBytes`, etc.). Since `RealtimeMetrics` is a
static-only utility class, please also delete its constructor and destructor to
prevent meaningless instances, as required by `docs/code-style.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
