jianguotian commented on code in PR #9802:
URL: https://github.com/apache/paimon/pull/9802#discussion_r4003930457
##########
paimon-api/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -599,6 +599,20 @@ public InlineElement getDescription() {
+ " skipped. Set to a larger value to
allow more aggressive"
+ " sort rewriting. The cap only limits
the sorted rewrite portion and full/minor cleanup may still happen beyond it.");
+ @ExcludeFromDocumentation("Only used by compact_manifest maintenance
procedure")
+ public static final ConfigOption<Boolean> MANIFEST_SORT_FORCE_REWRITE =
+ key("manifest-sort.force-rewrite")
Review Comment:
Thanks. I removed the force option; `compact_manifest` now performs a full
sort by default using the table options.
##########
paimon-core/src/main/java/org/apache/paimon/operation/ManifestFileSorter.java:
##########
@@ -862,18 +888,6 @@ private static void rewriteSections(
for (int i = 0; i < sections.size(); i++) {
Section section = sections.get(i);
- // A single-file section is always handled directly, regardless of
the budget.
- if (section.files.size() == 1) {
- rewriteSection(
- section.files,
- output,
- sortNewFiles,
- ctx,
- manifestFile,
- manifestReadParallelism);
- continue;
- }
-
// Phase 1: budget not yet exhausted -- perform aggressive sort
rewrite.
Review Comment:
Thanks. I restored the singleton shortcut for ordinary compaction while
keeping singleton rewrites for explicit full sort, and added a regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
