lxy-9602 commented on code in PR #346:
URL: https://github.com/apache/paimon-cpp/pull/346#discussion_r4013210829
##########
src/paimon/format/parquet/column_index_filter.cpp:
##########
@@ -68,7 +70,8 @@ Result<RowRanges> ColumnIndexFilter::VisitPredicate(
Result<RowRanges> ColumnIndexFilter::VisitLeafPredicate(
const std::shared_ptr<LeafPredicate>& leaf_predicate,
const std::map<std::string, int32_t>& column_name_to_index, int64_t
row_group_row_count,
- ::parquet::RowGroupPageIndexReader* rg_page_index_reader) {
+ ::parquet::RowGroupPageIndexReader* rg_page_index_reader,
+ const ::parquet::SchemaDescriptor* schema) {
const std::string& field_name = leaf_predicate->FieldName();
Review Comment:
Could you please keep output parameters at the end? If `schema` is a
`const*`, please place it in the middle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
