JingsongLi commented on code in PR #9874:
URL: https://github.com/apache/paimon/pull/9874#discussion_r4023591019
##########
paimon-api/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -3366,6 +3366,13 @@ public boolean fieldAggIgnoreRetract(String fieldName) {
.defaultValue(false));
}
+ public boolean fieldSumAggFailOnOverflow(String fieldName) {
+ return options.get(
+ key(FIELDS_PREFIX + "." + fieldName + ".sum.fail-on-overflow")
+ .booleanType()
+ .defaultValue(true));
Review Comment:
Maybe default value should be false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]