JingsongLi commented on code in PR #9897:
URL: https://github.com/apache/paimon/pull/9897#discussion_r4032709023
##########
paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFile.java:
##########
@@ -140,9 +144,33 @@ public <T> List<T> read(
Filter<InternalRow> readFilter,
Filter<ManifestEntry> readTFilter,
Function<ManifestEntry, T> convertor) {
+ return read(
+ fileName,
+ fileSize,
+ partitionFilter,
+ bucketFilter,
+ readFilter,
+ readTFilter,
+ convertor,
+ null);
+ }
+
+ public <T> List<T> read(
+ String fileName,
+ @Nullable Long fileSize,
+ @Nullable PartitionPredicate partitionFilter,
+ @Nullable BucketFilter bucketFilter,
+ Filter<InternalRow> readFilter,
+ Filter<ManifestEntry> readTFilter,
+ Function<ManifestEntry, T> convertor,
+ @Nullable ManifestSidecar.Selection selected) {
+ if (selected != null && selected.blocks().isEmpty()) {
+ return java.util.Collections.emptyList();
+ }
try {
Path path = pathFactory.toPath(fileName);
- if (cache != null) {
+ // Sidecar selections use the block cache, even when every block
is selected.
+ if (cache != null && selected == null) {
Review Comment:
Please fix this in next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
