JingsongLi commented on PR #9871: URL: https://github.com/apache/paimon/pull/9871#issuecomment-5708355910
Useful feature — per-table engine options remove the all-or-nothing `--table-conf` for database sync. One issue: `CdcActionCommonUtilsTest.testRejectSinkConfiguration()` is missing its `@Test` annotation, so it never runs. It covers exactly the new validation (rejecting per-table `sink.*` keys), so it should be executed. One behavior question: per-table keys that match no synchronized source table are silently accepted (`parseTableConfigByTable` just builds the map, and the override is looked up by exact table name). A typo such as `oder:bucket=8`, or a case mismatch, configures nothing with no signal at all. A warning listing unmatched keys (or validating against the discovered source tables) would save users a lot of debugging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
