JingsongLi commented on PR #9870: URL: https://github.com/apache/paimon/pull/9870#issuecomment-5708356282
Good catch. Two distinct fixes here, both correct: - `FieldCollectAgg` built the equaliser only when `distinct` was true, but `retract()` needs content equality regardless of distinct, so binary elements accumulated through retract could not be found/removed. Building it whenever the element type needs it, and gating only the `agg()` de-duplication on `distinct`, is the right split. - Extending the byte[]-valued set to `GEOMETRY`/`GEOGRAPHY` is warranted: their roots carry only the `PREDEFINED` family, so the old `BINARY_STRING` family check missed them and their elements compared by identity. This also fixes `FieldMergeMapAgg`/`FieldMergeMapWithKeyTimeAgg`, which share `BinaryMapKeys`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
