JingsongLi commented on code in PR #9924:
URL: https://github.com/apache/paimon/pull/9924#discussion_r4035546639
##########
paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFile.java:
##########
@@ -402,8 +402,8 @@ public ManifestSidecar.Selection selectBlocks(
@Nullable RowRangeIndex query,
@Nullable PartitionPredicate partitionFilter,
@Nullable BucketFilter bucketFilter) {
- return !options.manifestSidecarEnabled()
- || (query == null && partitionFilter == null &&
bucketFilter == null)
+ boolean hasFilter = query != null || partitionFilter != null ||
bucketFilter != null;
+ return !options.manifestSidecarEnabled() || (!hasFilter && cache ==
null)
Review Comment:
Fixed in d3e178e297. The selected-block reader now tracks actual block-cache
accesses and reports exactly one manifest-level hit or miss after each read:
any uncached selected block is a miss, while an all-block cache hit is a hit.
The regression test covers one cold unfiltered read followed by one warm
unfiltered read and verifies both I/O and the hit/miss counters. Five focused
ManifestFile tests and the paimon-core compile with Checkstyle/Spotless pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
