zhuxiangyi commented on PR #9940: URL: https://github.com/apache/paimon/pull/9940#issuecomment-5724468872
Thanks. On the duplicate-key note: that guarantee is still there, one line lower — `new RowType(fields)` runs `RowType.validateFields`, which rejects duplicate names with `Field names must be unique. Found duplicates: [...]`, so an object with two fields sharing a key still fails inference rather than producing a RowType with duplicate fields (and never reaches `mergeRowTypes`). The builder also refuses to produce such an object in the first place (`allowDuplicateKeys=false`). So I have left it without an extra adjacency check; happy to add one if you would rather have the explicit message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
