danzhewuju commented on PR #9933: URL: https://github.com/apache/paimon/pull/9933#issuecomment-5724881073
> One question on semantics: `abort()` now sets `closed = true`. That means after an abort, `result()` and `drainAbortExecutors()` no longer hit the `checkState(closed)` / `checkState(!closed)` guards — `result()` would happily hand out metadata for files that abort just deleted. Previously, a post-abort `result()` failed fast. Was this intentional? If callers might call `result()` after a failed write, a separate `aborted` flag (with `result()` still failing after abort, while abort/close stay idempotent) would preserve the old safety check. Thank you for your review. I think adding an ‘aborted’ flag is more reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
