lszskye commented on code in PR #362: URL: https://github.com/apache/paimon-cpp/pull/362#discussion_r4044802134
########## test/test_data/orc/append_types_compatibility.db/java_time_types/README.md: ########## @@ -0,0 +1,18 @@ +Schema: + +id INT NOT NULL +f_time_0 TIME(0) +f_time_3 TIME(3) +f_time_6 TIME(6) +f_time_9 TIME(9) + +Options: bucket = -1, file.format = orc, and orc.timestamp-ltz.legacy.type = false. The table +is unpartitioned and has no primary key. + +Add: (1, 12:34:56, 12:34:56.123, 12:34:56.123000, 12:34:56.123000000) +Add: (2, null, null, null, null) +Add: (3, 00:00:00, 00:00:00.000, 00:00:00.000000, 00:00:00.000000000) + +Paimon C++ is expected to reject this table while TIME is unsupported. Paimon's internal TIME +value is milliseconds since midnight, so the precision-6 and precision-9 declarations do not add Review Comment: what's the meaning of `midnight` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
