JingsongLi commented on PR #873: URL: https://github.com/apache/paimon-rust/pull/873#issuecomment-5731756967
Could we preserve `LocalSet` compatibility here? `RuntimeFlavor::MultiThread` does not guarantee that `block_in_place` is allowed. A `LocalSet` running on a multi-thread runtime still disallows in-place blocking. I reproduced this by calling `PaimonCatalogProvider::schema_names()` inside `LocalSet::run_until(...)`. The same test passes with the previous implementation, but this change causes it to panic at `block_in_place`: ```text can call blocking only when running on the multi-threaded runtime ``` The single-worker starvation fix works as intended, but this introduces a regression for callers using `LocalSet`. Could we add a regression test and retain a compatible execution path for contexts that disallow in-place blocking, rather than relying solely on `runtime_flavor()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
