JingsongLi commented on PR #9682:
URL: https://github.com/apache/paimon/pull/9682#issuecomment-5738294634
The MAP fix itself looks right: `MAP` / `MAP NOT NULL` matches the canonical
Java tag (`MapType.java:90`), the parser accepts both the canonical and legacy
`MAP<...>` forms, and the tests cover the nullability matrix.
One same-class gap is left behind: `MultisetType.to_dict()`
(`paimon-python/pypaimon/schema/data_types.py:221-227`) still emits the
embedded-element form `{"type": "MULTISET<...>", "element": ..., "nullable":
...}`. Since `_resolved_schema_json` serializes every field of the table
schema, any table with a MULTISET column would hit the same native-plan failure
this PR fixes for MAP:
```text
Invalid table schema JSON: unknown variant `MULTISET<...>`,
expected one of `ARRAY`, `MAP`, `MULTISET`, `ROW`, `VECTOR`
```
The canonical tag already exists on the Java side (`MultisetType.java:83`
emits `MULTISET` / `MULTISET NOT NULL`), and the Python parser's `MULTISET`
branch (`data_types.py:573-578`) accepts both forms, so switching the tag would
be backward compatible. Could you extend the same fix and tests to MULTISET
here, or file a follow-up so the native path is not left half-fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
