zjw1111 commented on code in PR #370:
URL: https://github.com/apache/paimon-cpp/pull/370#discussion_r4055943464
##########
src/paimon/core/operation/raw_file_split_read.cpp:
##########
@@ -189,91 +180,4 @@ Result<bool> RawFileSplitRead::Match(const
std::shared_ptr<Split>& split,
return matched;
}
-Result<std::unique_ptr<FileBatchReader>>
RawFileSplitRead::ApplyIndexAndDvReaderIfNeeded(
- std::unique_ptr<FileBatchReader>&& file_reader, const
std::shared_ptr<DataFileMeta>& file,
- const std::shared_ptr<arrow::Schema>& data_schema,
- const std::shared_ptr<arrow::Schema>& read_schema, const
std::shared_ptr<Predicate>& predicate,
- DeletionVector::Factory dv_factory, const
std::optional<std::vector<Range>>& ranges,
- const std::shared_ptr<DataFilePathFactory>& data_file_path_factory) const {
- std::shared_ptr<FileIndexResult> file_index_result;
- if (options_.FileIndexReadEnabled()) {
- PAIMON_ASSIGN_OR_RAISE(
- file_index_result,
- FileIndexEvaluator::Evaluate(data_schema, predicate,
data_file_path_factory, file,
- options_.GetFileSystem(), pool_));
- PAIMON_ASSIGN_OR_RAISE(bool is_remain, file_index_result->IsRemain());
- if (!is_remain) {
- return std::unique_ptr<FileBatchReader>();
- }
- }
- // prepare selection bitmap for index
Review Comment:
Do these comments still need to be kept? They have been deleted now after
the migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
