JingsongLi commented on code in PR #9999:
URL: https://github.com/apache/paimon/pull/9999#discussion_r4056475323
##########
paimon-python/pypaimon/globalindex/global_index_result.py:
##########
@@ -38,18 +42,20 @@ def offset(self, start_offset: int) -> 'GlobalIndexResult':
offset_bitmap = RoaringBitmap64()
for row_id in bitmap:
offset_bitmap.add(row_id + start_offset)
- return SimpleGlobalIndexResult(offset_bitmap)
+ return SimpleGlobalIndexResult(offset_bitmap, self.is_exact())
def and_(self, other: 'GlobalIndexResult') -> 'GlobalIndexResult':
"""Returns the intersection of this result and the other result."""
return SimpleGlobalIndexResult(
- RoaringBitmap64.and_(self.results(), other.results())
+ RoaringBitmap64.and_(self.results(), other.results()),
+ self.is_exact() and other.is_exact(),
Review Comment:
Fixed in 2d535e58e. I rechecked the same-leaf OR-exactness rule against
conjunction semantics and ran the focused suite: 12 passed, with 33 optional
vector-index cases skipped because paimon_vindex is unavailable locally. This
resolves the finding. +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
