JingsongLi commented on PR #696: URL: https://github.com/apache/paimon-rust/pull/696#issuecomment-5771939028
Requirement fit: **SUPPORTED**. Implementation: **FINDINGS**, reviewed at `45e887beb14cd1f67b1ae3ca5bfb10b26fdb21bc`. The opt-in planning backend has a concrete consumer in the merged apache/paimon#9124, and the supplied measurements demonstrate an end-to-end planning benefit for the two tested snapshots. Keeping the claim scoped to planning is appropriate: the reported data reads are slightly slower and request/QPS effects remain unmeasured. **[P2] Preserve explicit SDK environment selection before Python auto-discovery.** In [`bindings/python/src/context.rs:122-124`](https://github.com/apache/paimon-rust/blob/45e887beb14cd1f67b1ae3ca5bfb10b26fdb21bc/bindings/python/src/context.rs#L122-L124), a user who sets `JINDOSDK_LIBRARY_PATH` (or `JINDOSDK_HOME`) and has `pyjindo` installed gets `fs.jindo.library.path` injected from the Python package. `library_candidates` then treats that injected value as an exclusive explicit path and never consults the user's environment. Thus the documented SDK selection works for Rust callers but selects a different SDK through Python; if the package's library is not loadable, even a valid environment-selected SDK cannot be used. Please skip package discovery when either explicit SDK environment setting is present, or make package discovery a fallback after those settings, and cover this precedence in a binding test. I traced configuration, lazy initialization, paginated listing, ranged reads, read-only operations, and the FileIO callers. `cargo +1.94.0 test -p paimon --features storage-jindo --lib storage_jindo` passes all 6 tests locally. I did not rerun the native SDK/OSS probes or the reported benchmarks; these unit tests do not validate the dynamic ABI or live storage behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
