jianguotian commented on code in PR #97:
URL: https://github.com/apache/paimon-mosaic/pull/97#discussion_r4070241505


##########
python/setup.py:
##########
@@ -53,6 +61,31 @@ def _find_native_lib():
     return None
 
 
+def _stage_legal_files(destination_dir):
+    here = os.path.dirname(os.path.abspath(__file__))
+    staged = []
+
+    for name in LEGAL_FILES:
+        source = os.path.join(here, LEGAL_SOURCE_FILES[name])
+        destination = os.path.join(destination_dir, name)
+        if not os.path.isfile(source):
+            raise RuntimeError(f"required binary legal file is missing: 
{source}")

Review Comment:
   Fixed in 982160c. Repository canonical files remain preferred, with an 
sdist-local fallback for both metadata and package staging. Added a RED/GREEN 
sdist-to-wheel regression; default builds, the reported pip wheel command, and 
installed-wheel native loading pass locally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to