jackylee-ch opened a new pull request, #10108:
URL: https://github.com/apache/paimon/pull/10108

   ### Purpose
   
   The bloom filter file index reads `items` and `fpp` from table options with 
no bounds. A percentage-shaped `fpp` like `10` makes every write fail with a 
bare `NegativeArraySizeException`; `fpp = 0` overflows the same way; `fpp = 1` 
or negative silently builds a one-byte filter that prunes nothing; a large 
`items` overflows the bit-set size.
   
   Reject `fpp` outside `(0, 1)` and non-positive `items` in the writer (the 
read path never consults them, so existing tables stay readable), and guard the 
bit-count overflow in `BloomFilter64`. A bad option now fails at write time 
naming it. Mirrors #9765 for range-bitmap `chunk-size`.
   
   ### Tests
   
   `BloomFilterFileIndexTest.testRejectsInvalidOptions`: `fpp` = 10 / 0 / 1.0 / 
-0.1, `items` = 0, `items = Integer.MAX_VALUE`, plus a valid config. Fails on 
master, passes here.
   
   Written with Claude Code; verification is mine.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to