JingsongLi opened a new pull request, #916:
URL: https://github.com/apache/paimon-rust/pull/916

   ## Summary
   
   Follow-up to #915; this branch is based on its current head (`d0948d23`). 
Until #915 is merged and this branch is rebased, the PR diff also includes that 
prerequisite. The new change is limited to the Python binding's batch identity 
bridge and its tests.
   
   - Add the internal `BatchWriteBuilder._with_commit_user()` bridge so 
PyPaimon can retain the identity of its Python writer when committing 
serialized messages through a native batch overwrite.
   - Validate the external user before updating builder state, using the same 
validation as the existing stream builder.
   - Keep the Java-style public batch/stream API: no public batch 
`with_commit_user`, no generic `Table.new_commit`, and no changes to the commit 
wire format.
   
   PyPaimon's existing native append bridge uses the stream builder to retain 
its commit user. Native overwrite uses the batch builder; this bridge lets it 
preserve the same identity without substituting a newly generated user.
   
   ## Verification
   
   - Built a Python wheel from #915 plus this change with `maturin build`.
   - `bindings/python/tests/test_table_commit.py`: **43 passed**. New tests 
cover local and deserialized fixed-bucket messages in append/overwrite mode, 
snapshot identity and batch identifier, and rejected identities leaving the 
prior builder identity intact.
   - The corresponding PyPaimon change passed **126 tests and 2 subtests** 
against this wheel, including static/dynamic/null partition overwrite, empty 
input and empty tables, response loss after publication, and preflight fallback.
   - `cargo fmt --all -- --check` and `git diff --check` passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to